Merged
Conversation
Member
Author
|
I think this should not land until we merge #16, otherwise the guide is not yet ready for publishing. |
bjohansebas
approved these changes
Jan 7, 2026
Member
Author
|
I noticed that the title isn't configured correctly because .bookignore is ignoring, er, the configuration by mistake. Removed it from the ignore file. |
Member
Author
|
Landing it with the fix - I think that should be tiny enough without a re-review (before, the pages contains "HonKit" in the title because the configuration wasn't effective due to the ignore) |
Member
Author
|
This is now live: https://nodejs.github.io/package-examples/ Unpublishing my fork.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on my fork: https://joyeecheung.github.io/package-examples/
Once merged, this will be published to https://nodejs.github.io/package-examples/
Refs: #17